Resolve #4746: Add total of FMVs to Purchase Index; Fix pagination of Amount spent #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cielf
previously requested changes
Dec 12, 2024
There was a problem hiding this comment.
Hi @Hungle2911 -- I do a functional review before the technical - I noticed that the "this page" value for the fair market value was wrong, so I dug a little to figure out why.
I also noticed that the body of the page isn't paging properly - but that's also not working on main and is out of the scope of this PR.
|
The out-of-scope problem mentioned above is addressed in PR #4854 |
|
The numbers LGTM -- @dorner -- we should get this and 4854 in on the same release. |
dorner
approved these changes
Dec 14, 2024
dorner
requested changes
Dec 14, 2024
|
Entirely expected. I'll take a look, but I expect them to be easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4746
Description
Add totals for the Fair Market Value to the current purchase index page. Fix pagination of Amount spent and FMV.
Type of change
How Has This Been Tested?
Screenshots