From 34815023f7f9d8ce123f38dc6363dd910c8f3be9 Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Fri, 29 Nov 2024 11:05:33 +0900 Subject: [PATCH 1/2] Enabled windows-latest on GHA --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 39d16289..48dd48e0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,7 +18,7 @@ jobs: strategy: matrix: ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }} - os: [ ubuntu-latest, macos-latest ] + os: [ ubuntu-latest, macos-latest, windows-latest ] experimental: [false] runs-on: ${{ matrix.os }} continue-on-error: ${{ matrix.experimental }} From 18cc951a657fc84753123f199a690ede66e3ecd8 Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Fri, 29 Nov 2024 11:10:30 +0900 Subject: [PATCH 2/2] Skip test_starttls_unknown_ca with Windows --- test/net/imap/test_imap.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/net/imap/test_imap.rb b/test/net/imap/test_imap.rb index c9fe5ae1..45145a7f 100644 --- a/test/net/imap/test_imap.rb +++ b/test/net/imap/test_imap.rb @@ -102,6 +102,8 @@ def test_imaps_post_connection_check if defined?(OpenSSL::SSL) def test_starttls_unknown_ca + omit "This test is not working with Windows" if RUBY_PLATFORM =~ /mswin|mingw/ + imap = nil assert_raise(OpenSSL::SSL::SSLError) do ex = nil