Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionCable benchmarks are broken #240

Open
bmarkons opened this issue Aug 7, 2017 · 2 comments
Open

ActionCable benchmarks are broken #240

bmarkons opened this issue Aug 7, 2017 · 2 comments

Comments

@bmarkons
Copy link
Contributor

bmarkons commented Aug 7, 2017

Following error is raised in ActionCable benchmarks:

/ruby-bench-suite/rails/benchmarks/support/actioncable_helpers.rb:34:in `<top (required)>': undefined method `channel_paths=' for #<ActionCable::Server::Configuration:0x007f17623a12b0> (NoMethodError)
        from /ruby-bench-suite/rails/benchmarks/bm_actioncable_redis.rb:5:in `require_relative'
        from /ruby-bench-suite/rails/benchmarks/bm_actioncable_redis.rb:5:in `<main>'
@robin850
Copy link
Member

robin850 commented Aug 7, 2017

Hi @bmarkons,

It looks like this method was removed in rails/rails@a8df1bc. Actually, it was not part of the public API so this explains why it hasn't gone through a deprecation cycle and it now fails.

I'm not sure this is needed anymore but I didn't test though. I hope this helped you ! :-)

@bmarkons
Copy link
Contributor Author

bmarkons commented Aug 8, 2017

Thanks @robin850 :) I suppose we should remove that method call then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants