Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User context launching logic needs update for Big Sur #69

Open
smashism opened this issue Nov 18, 2020 · 1 comment
Open

User context launching logic needs update for Big Sur #69

smashism opened this issue Nov 18, 2020 · 1 comment

Comments

@smashism
Copy link
Contributor

Heya, here's an example:

if [[ ${osvers_major} -eq 10 ]] && [[ ${osvers_minor} -ge 10 ]]; then

As-is this won't work on Big Sur now that it has decided to be 11.0 and not 10.16. We've updated the script internally to work with the following modification:
if [[ "$osvers_major" -eq 11 ]] || [[ "$osvers_major" -eq 10 && "$osvers_minor" -ge 10 ]]; then

I don't seem to be able to make a pull request for this but in case others are still using this script it might be helpful to update it. I think there are a few others that will need something similar.

Cheers!

@smashism
Copy link
Contributor Author

smashism commented Dec 8, 2020

Looks like https://github.com/rtrouton/rtrouton_scripts/blob/master/rtrouton_scripts/Casper_Scripts/open_macappstore_address_via_self_service/open_macappstore_address_via_self_service.sh needs the same TLC.

There may be others in the repo too that need a similar update; we keep stumbling upon them internally ourselves.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant