Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait_for_server should use walltime #137

Open
beetleskin opened this issue May 20, 2019 · 0 comments · May be fixed by #138
Open

wait_for_server should use walltime #137

beetleskin opened this issue May 20, 2019 · 0 comments · May be fixed by #138

Comments

@beetleskin
Copy link

beetleskin commented May 20, 2019 •
edited
Loading

wait_for_server() uses ros-time for checking how much time passed. This has two issues when using sim time

  • the function never returns when /clock is never published, which is unexpected
  • the function returns too early, if time gets initialized while wait_for_service() is running

The function should behave like its bigger brother wait_for_service().

This was already addressed in #19, and fixed in esteve@3dd09c5. We need to port this fix onto the current master branch.

See also:
@beetleskin beetleskin linked a pull request May 20, 2019 that will close this issue
Open
@beetleskin beetleskin changed the title wait_for_service should use walltime wait_for_server should use walltime May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sim time wait (#137) beetleskin/actionlib
1 participant
@beetleskin