rospkg identifies macOS sierra and later as "OS X"

[rotu]

Internally and in stack traces, rospkg identifies macOS sierra as "OS X". The string identifying mac when using this platform is "osx" which is increasingly incorrect. The official name since Sierra is "macOS" so "OS X" is incorrect/misleading.

[dirk-thomas]

When the logic was implemented the official name was "OS X". Please consider contributing a pull request to update it.

[erickisos]

Hey everyone!

I just want to know what's the difference of being detected as OSX vs macOS? I mean, in the functional sense does it have some difference?

[christophebedard]

I mean, in the functional sense does it have some difference?

I don't think so, but it does need to be "osx" for other things to work. The rosdep lists, for example: https://github.com/ros/rosdistro/blob/master/rosdep/osx-homebrew.yaml. So if we were to change it to "macos" we'd need to change it everywhere.

[erickisos]

So, we can keep this as OSX but first, we need to be sure that this is working on macOS sierra and higher, that's right?

I mean, i saw the #210 issue and I just want to be sure if it's related based on the id of OS, but it sounds like a different beast to me (related, but different).

[christophebedard]

It does currently work! See #216 for Big Sur and #229 for Monterey.

[CursedRock17]

If it currently works as valid naming conventions, should this issue be closed? Especially since ventura was also recently added without problems.

[christophebedard]

From what I understand, this issue is not about supporting newer versions. It's about the name of the OS being "macOS" now and not "OS X" like rospkg reports