Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata sync Net::ReadTimeout: Net::ReadTimeout #562

Open
keang opened this issue Nov 22, 2016 · 1 comment
Open

Metadata sync Net::ReadTimeout: Net::ReadTimeout #562

keang opened this issue Nov 22, 2016 · 1 comment

Comments

@keang
Copy link
Contributor

keang commented Nov 22, 2016

https://rollbar.com/Roomorama/Concierge/items/679/
Strange that no external error is created

@kkolotyuk
Copy link
Contributor

kkolotyuk commented Nov 22, 2016

Strange that no external error is created

Looks like the error occurred during Rollbar warning operation and we don't handle exceptions and don't wrap them in Result.error. May be this is a sign to wrap listener.call here:

def trigger(event, *args)
  listeners[event].map do |listener|
    listener.call(*args)
  end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants