Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking not_available response #559

Open
3 of 10 tasks
kkolotyuk opened this issue Nov 21, 2016 · 1 comment
Open
3 of 10 tasks

Booking not_available response #559

kkolotyuk opened this issue Nov 21, 2016 · 1 comment

Comments

@kkolotyuk
Copy link
Contributor

kkolotyuk commented Nov 21, 2016

We decided to unify booking error codes as we did for quote request. Concierge::Errors::Booking contains all common cases for booking unsuccessful scenarios. Currently there is only one: property is not available. So we need to change all the suppliers to support this error.

  • THH

  • Poplidays

  • SAW

  • JTB

  • Avantio

  • Kigo

  • KigoLegacy

  • Ciirus

  • waytostay

  • rentals united

@sharipov-ru
Copy link
Contributor

sharipov-ru commented Nov 25, 2016

I started applying Concierge::Errors::Booking module to rentals united and my specs failed. The problem is in missing mismatch call if I do something like this:

  return not_available if code == NOT_AVAILABLE_ERROR_CODE

What you guys think about adding mismatch call directly inside not_available method of the module?

I suggest to make a decision which side should be responsible for that: common module or every supplier's integration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants