Change host_fee calculation

[keang]

We need to change the way we calculate the "host fee" value.

Currently we use this formula:

net_rate = price / (1 + host_fee_percentage)

But we now need to change it to:

net_rate = price * host_fee_percentage

This applies to all the suppliers and all the hosts.

[kkolotyuk]

One more bug there, we tried to find property by property_id

  def property
    @property ||= PropertyRepository.identified_by(property_id).first
  end

But property_id is not unique in our DB (((

[keang]

oh man

[kkolotyuk]

Also I don't get the point of this issue. Why do we need to change the formula? Looks like it really calculate the price without host_fee:

2.3.1 :001 > q = ::Quotation.new({total: 1000, property_id: '147347|1444666941|whereinrio'})
2.3.1 :007 > q.host_fee_percentage
 => 5.0
2.3.1 :008 > q.net_rate
 => 952.38

[kkolotyuk]

Ahhhh I see, the right answer is 1000 - 5% = 950

[kkolotyuk]

Here is the right formula:

  # The quotation without host fee
  def net_rate
    coefficient = 1 - host_fee_percentage.to_f / 100
    (total * coefficient).round(2)
  end

Test:

2.3.1 :001 > q = ::Quotation.new({total: 1000, property_id: '147347|1444666941|whereinrio'})
2.3.1 :007 > q.host_fee_percentage
 => 5.0
2.3.1 :008 > q.net_rate
 => 950.0

[kkolotyuk]

Can I fix this?

[keang]

Not this week =)

[keang]

Actually yes sure!

[kkolotyuk]

Fixed net_rate calculation and add new issue #509 for wrong property bug