Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property description #503

Open
kkolotyuk opened this issue Oct 31, 2016 · 1 comment
Open

Property description #503

kkolotyuk opened this issue Oct 31, 2016 · 1 comment
Labels
kigo poplidays

Comments

@kkolotyuk
Copy link
Contributor

kkolotyuk commented Oct 31, 2016 •
edited by keang
Loading

Description

Rollbar contains a lot of empty description errors for poplidays: https://rollbar.com/Roomorama/Concierge/items/317/?item_page=0&item_count=100&#instances
I checked a couple of such properties and found that they are valid and actual on Poplidays site, so I don't see a reason to not import them to Roomorama.

Possible solutions

Use title as description for properties without description.

Occurrences
@keang
Copy link
Contributor

keang commented Nov 2, 2016

We can use the metadata of the properties to generate description:
A template is found here
https://docs.google.com/a/roomorama.com/spreadsheets/d/17DOdZOGzNGN2e_toCmA0Q_t9TzHjr_c8Pj-2BzYfDUg/edit?usp=sharing

We should put more cases in the above spreadsheet before starting any work on this..

@keang keang mentioned this issue Nov 2, 2016
Closed
@keang keang added the kigo label Nov 2, 2016
This was referenced Nov 21, 2016
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kigo poplidays
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkolotyuk @keang