Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No images for property #285

Open
rmascarenhas opened this issue Aug 27, 2016 · 2 comments
Open

No images for property #285

rmascarenhas opened this issue Aug 27, 2016 · 2 comments

Comments

@rmascarenhas
Copy link
Contributor

Description

When mapping data from WayToStay's API to Roomorama's format, sometimes no images are set for a property. In such cases, the publish request is not even set to Roomorama, and the process is aborted.

Possible solutions

Apparently #263 was supposed to fix this issue (or a similar one), but there are still occurrences in version 0.7.3 (see Occurrences section.)

@keang correct me if I'm misinterpreting something.

Occurrences

#307054, #307053, #307051

@leandrocg
Copy link

@keang
"Aborting the process" seems like a serious problem. Can you please take a look to check if it was fixed?

@rmascarenhas
Copy link
Contributor Author

Perhaps my choice of words were not the best here. What I meant by "aborting the process" is that the request is not even sent to Roomorama since no images were added to the property.

Then that property fails, but the synchronisation keeps going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants