Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote calls for number of guests larger than that allowed #281

Open
rmascarenhas opened this issue Aug 27, 2016 · 6 comments
Open

Quote calls for number of guests larger than that allowed #281

rmascarenhas opened this issue Aug 27, 2016 · 6 comments

Comments

@rmascarenhas
Copy link
Contributor

Description

Some quote requests are arriving for Concierge where the number of guests is larger than the maximum number of guests, a known configuration

Possible solutions

We should not quote stays when the requested number of guests is larger than that allowed. This is a fix on Roomorama, but I decided to address it here to group supplier improvements.

Occurrences

#307492, #307491

@leandrocg
Copy link

Impact on scalability, not urgent. Is it still open?

@rmascarenhas
Copy link
Contributor Author

Yes, still open. Just trying to minimise calls to WayToStay to avoid using our limited API quota.

@keang
Copy link
Contributor

keang commented Sep 16, 2016

This should be fixed by https://github.com/roomorama/roomorama/pull/3818?

@rmascarenhas
Copy link
Contributor Author

Yes, hopefully no longer happening after the next Roomorama release 👍

@keang
Copy link
Contributor

keang commented Sep 27, 2016

There is a property that has this information outdated:
https://concierge-web.roomorama.com/errors/456268

Probably something happened during the WayToStay changes call that included this property. Calls subsequently doesn't include this property anymore :/

2.2.5 :015 > Room.find_by(internal_id: "015132").updated_at
 => Tue, 19 Jul 2016 04:14:43 UTC +00:00

Actions to take would be:

  • Try to force a sync with all changes from a very early date. See if the property is updated correctly.
  • Track down when that property was updated and since when waytostay has been out of sync?()

@keang
Copy link
Contributor

keang commented Nov 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants