-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix margins #36
Comments
Fil
added a commit
that referenced
this issue
Jan 20, 2020
Here we have 20 horizontal yearly series of 12 monthly values with valueHeight = max(monthly values) for each year. Adding margins in [email protected] will "eat" the content of the smaller series and give them negative heights. When it's fixed we see all the series, and they share the available space evenly as a proportion of their valueHeight: |
Fil
added a commit
that referenced
this issue
Jan 21, 2020
more or less fixed in #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
margins are problematic, they tend to erase smaller contents by giving it negative height or width.
I've fixed the case of "height" in the "horizontal" gridding mode, but it needs to be generalized and unit tested.
The text was updated successfully, but these errors were encountered: