Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build and dependencies #29

Closed
romsson opened this issue Apr 28, 2019 · 3 comments
Closed

Fix build and dependencies #29

romsson opened this issue Apr 28, 2019 · 3 comments
Assignees
@romsson

Comments

@romsson
Copy link
Owner

romsson commented Apr 28, 2019

Do some diagnostics using npm audit

Check status using README.MD badges
@romsson romsson self-assigned this Apr 28, 2019
@severo
Copy link
Collaborator

severo commented Sep 16, 2019 •
edited
Loading

See also npm outdated and https://docs.npmjs.com/misc/scripts#prepublish-and-prepare (replace prepublish by prepare or prepublishOnly).

@Fil
Copy link
Collaborator

Fil commented Dec 3, 2019 •
edited
Loading

There is an incompatibility with https://github.com/d3/d3-scale/releases/tag/v2.2.0

building with [email protected] is fine, afterwards 2 tests are broken, probably due to d3/d3-scale#117

I think I'll just remove those tests :)

Fil added a commit that referenced this issue Dec 3, 2019
@Fil
Fix build and dependencies
363c40e 
See #29

Unfortunately we can't build with d3-scale > 2.1.2, there is an incompatibility with https://github.com/d3/d3-scale/releases/tag/v2.2.0 — probably due to d3/d3-scale#117
@Fil Fil mentioned this issue Dec 3, 2019
Open
@Fil
Copy link
Collaborator

Fil commented Dec 3, 2019

all fixed except d3-scale@3 which is now in #35

@Fil Fil closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romsson romsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fil @romsson @severo