Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on ROM - Quick Start #313

Open
qortex opened this issue Mar 30, 2020 · 3 comments
Open

Feedback on ROM - Quick Start #313

qortex opened this issue Mar 30, 2020 · 3 comments

Comments

@qortex
Copy link

qortex commented Mar 30, 2020

On page: https://rom-rb.org/learn/repository/5.2/quick-start/

Now we have a full CRUD setup, we can create, update and delete user data:

As far as I understand, the snippet gives CUD capabilities, but not a Read capability, which would need to add a selector that routes to a Relation selector method.

@solnic
Copy link
Member

solnic commented Mar 31, 2020

@MicMicMon technically speaking, repositories have full support for CRUD w/o commands declaration. You have access to all relations and they expose CRUD interface. How you encapsulate CRUD is important. That's why repositories exist - a place to encapsulate data access. This whole section should be improved or even rewritten to be honest.

For now we can just change this confusing sentence to:

Now we have a full CUD setup, we can create, update and delete user data:

@qortex
Copy link
Author

qortex commented Mar 31, 2020

Ah ok. Indeed, that's not what I understood from the writeup :)

If you're interested, I can give a shot at a doc PR when I get my head around the various concepts. I guess it could be interesting coming from someone like me who has no prior background on ROM.

@solnic
Copy link
Member

solnic commented Apr 1, 2020

@MicMicMon sure! contributions like that are always welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants