Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use contexts with timeouts in tests #33

Open
tzdybal opened this issue Nov 7, 2024 · 0 comments
Open

Use contexts with timeouts in tests #33

tzdybal opened this issue Nov 7, 2024 · 0 comments
Labels
execution-api T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. testing

Comments

@tzdybal
Copy link
Member

tzdybal commented Nov 7, 2024

Currently tests use context.TODO() - this should be replaced with something like:

ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
defer cancel()
@tzdybal tzdybal added testing T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Nov 7, 2024
@tzdybal tzdybal mentioned this issue Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
execution-api T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. testing
Projects
Rollkit
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tzdybal