Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ScriptContext.Error to filter out unrelated error messages #26

Open
osyrisrblx opened this issue May 26, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@osyrisrblx
Copy link

osyrisrblx commented May 26, 2022

Currently, run-in-roblox uses LogService.MessageOut and will set the exit code to 1 if the messageType == Enum.MessageType.MessageError. However, occasionally Studio will report internal Roblox errors like "Studio beta features failed to fetch". This will cause run-in-roblox to exit with a status code of 1 even if none of the user code had an error.

Instead, maybe run-in-roblox should use ScriptContext.Error to determine the status code and continue to use LogService.MessageOut for logging. ScriptContext.Error provides a reference to the script that errored.

We can probably safely ignore any script errors from outside common services like:

  • Workspace
  • ServerScriptService
  • ReplicatedStorage
  • StarterPlayer.StarterPlayerScripts?
@LPGhatguy LPGhatguy added the enhancement New feature or request label May 26, 2022
@Dionysusnu
Copy link

Run-in-roblox knows the script to run from the command-line argument. Is it reasonably possible to figure out if errors originate from that callstack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants