You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a good safety check after extracting, but would be even more useful as a fallback during extraction. We already implement this detection for all supported platforms (Windows, macOS, Linux) and architectures (X86, X64, aarch64, arm32).
It would also be nice to warn whenever this fallback gets triggered since release artifacts having uniform naming and proper executables inside them is generally a good idea.
The text was updated successfully, but these errors were encountered:
Rokit currently uses an extraction process very similar to Foreman and Aftman:
This usually works but in some rare cases it may not:
There exists a solution for this and one that Rokit already partially implements - checking the binary contents in artifacts:
https://github.com/filiptibell/rokit/blob/6ecef4fdb14911005126f23010464476380368c7/lib/sources/artifact.rs#L193-L205
This is a good safety check after extracting, but would be even more useful as a fallback during extraction. We already implement this detection for all supported platforms (Windows, macOS, Linux) and architectures (X86, X64, aarch64, arm32).
It would also be nice to warn whenever this fallback gets triggered since release artifacts having uniform naming and proper executables inside them is generally a good idea.
The text was updated successfully, but these errors were encountered: