Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panics shouldn't crash the entire server #99

Open
alexashley opened this issue Oct 13, 2021 · 0 comments
Open

Panics shouldn't crash the entire server #99

alexashley opened this issue Oct 13, 2021 · 0 comments

Comments

@alexashley
Copy link
Contributor

See #98 for an example of a request the currently crashes grafeas-elasticsearch. In Rode, we use the grpc-recovery middleware to catch panics and return codes.Internal.

Grafeas doesn't appear to expose any options for configuring the gRPC server with additional interceptors, so we might have to wrap each storage method implementation with a function to recover from panics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant