Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumes UI: "View" is unclear #92

Closed
hannesm opened this issue Nov 13, 2024 · 4 comments
Closed

Volumes UI: "View" is unclear #92

hannesm opened this issue Nov 13, 2024 · 4 comments
Assignees

Comments

@hannesm
Copy link
Contributor

hannesm commented Nov 13, 2024

The volumes UI looks amazing. But I initially was confused by the View button -- since I expected to get the data of the volume -- but instead I was redirected to the unikernel that is using the block device.

Since the "get" and "set" operations are to be implemented (see #32), we should find some good names for the buttons :)

I also like the pie chart a lot. Thanks so much @PizieDust :)

@PizieDust
Copy link
Collaborator

Yes that's right. "View" is not very explanatory.
I was thinking of a way to display the data. For instance if we read data from a block device, do we just display this as text? What is the data corresponds to images?

Also, the way I understand the "get" operation, we have to give it an offset so it reads to that offset?

@hannesm
Copy link
Contributor Author

hannesm commented Nov 13, 2024

Yes that's right. "View" is not very explanatory. I was thinking of a way to display the data. For instance if we read data from a block device, do we just display this as text? What is the data corresponds to images?

I'd have a "download" button, and allow the data to be downloaded as application/octet-stream.

Also, the way I understand the "get" operation, we have to give it an offset so it reads to that offset?

The int provided to `Block_dump is the compression level to use. 0 for none, 9 for highest (I guess). It uses https://github.com/mirage/decompress.

@PizieDust
Copy link
Collaborator

PizieDust commented Nov 13, 2024 via email

@hannesm
Copy link
Contributor Author

hannesm commented Nov 20, 2024

#95 addresses this

@hannesm hannesm closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants