Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A collection of issues from thorough testing. #10

Open
andrewglanzzz opened this issue Apr 6, 2023 · 0 comments
Open

A collection of issues from thorough testing. #10

andrewglanzzz opened this issue Apr 6, 2023 · 0 comments

Comments

@andrewglanzzz
Copy link
Collaborator

Ran through and tried to break as much as I could, here's what I've found:

  1. Search Filtering is non functional for the most part:
  • Chord Root filtering is non-functional.
  • Chord Quality is non-functional. This might need to be cut or completely reworked.
  • Genre filtering does not actually filter. Need to look at the code and see why this is happening.
  • Difficulty filtering is exhibiting the same behavior as Genre filtering. Code needs to be looked at.
  1. When viewing a Chord Chart for a song on the search page, the username of the user who submitted the song is not shown.
    image

The submission preview shows this behavior. Needs to be fixed... should be easy.
image

  1. On submit a song when searching chords to be applied, if no chords are returned by a search, the entire modal disappears.
    image
    This is an issue due to the modal resizing based off of the content inside of it. We should consider setting a minimum size to a fixed value to prevent this from happening.

In terms of things that are not broken but could use some tweaking:

  • On the Chord Recognition page, if you use the Live Chord Recognition, it will accurately detect chords. Not an issue. If you switch to Chord Recognition from a file, the Chord Detected array is not automatically cleared. Small issue, but could be fixed for cleanliness. We could add a trigger to the button that just clears the array.
  • Home page guitar PNG has a slight outline that is visible and the text on the home page is no longer contained in the guitar. This could be due to my monitor being 1440p, but I am not sure. I've noticed that moving and resizing the page completely messes with the layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant