Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry through Exit Code #42

Open
bdowne01 opened this issue Nov 11, 2022 · 1 comment
Open

Carry through Exit Code #42

bdowne01 opened this issue Nov 11, 2022 · 1 comment

Comments

@bdowne01
Copy link

Hi, thanks for such a useful action!

After trying this out, I'm a little confused on how to properly fail the workflow job if one of the terraform steps fail.

We're passing continue-on-error: true to the terraform step, like the example shows. It seems the commenter step(s) should exit non-zero after posting the comment as to stop processing subsequent job steps, but the commenter exits zero even when it was handed a non-zero from the terraform wrapper.

I feel like I'm missing something obvious but the readme states

In English: "Always run this step, but only on a pull request and only when the previous step succeeds or fails...and then stop the build.

What trigger should be used stop the build?

Thanks again!

@JensRantil
Copy link

Completely agree with this one. I think the exit code should carry through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants