Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Create subdomain fails on public networks #112

Open
ilanolkies opened this issue Jun 12, 2020 · 1 comment
Open

Create subdomain fails on public networks #112

ilanolkies opened this issue Jun 12, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
v1.8.2

Comments

@ilanolkies
Copy link
Contributor

Validations in create subdomain endpoint are being executed before transactions. This makes the library fail when setting a new owner for a subdomain and its address.
@ilanolkies ilanolkies added the bug Something isn't working label Jun 12, 2020
@ilanolkies ilanolkies added this to the v1.8.2 milestone Jun 12, 2020
@ilanolkies ilanolkies mentioned this issue Jun 26, 2020
Merged
@ilanolkies
Copy link
Contributor Author

Part of this issue is solved by #115. Now the challenge is to estimate the gas before some transactions are executed. setAddr dependes on setOwner, its estimation should happen after setAddr world state update finished. Same for setSubnodeOwner.

@pmprete pmprete mentioned this issue Oct 31, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.8.2
Development

No branches or pull requests
1 participant
@ilanolkies