Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on Manjaro #163

Closed
grodin opened this issue Feb 7, 2024 · 10 comments · Fixed by #165
Closed

Doesn't work on Manjaro #163

grodin opened this issue Feb 7, 2024 · 10 comments · Fixed by #165

Comments

@grodin
Copy link

grodin commented Feb 7, 2024

Not sure if Manjaro is supposed to be supported (if not, fair enough!), but currently running reboot-arch-btw gives the error

[2024-02-07T10:36:16Z ERROR reboot_arch_btw] Could not create kernel checker: Could not get version of installed kernel: could not find or read package

The output of uname -srv is

Linux 6.1.71-1-MANJARO #1 SMP PREEMPT_DYNAMIC Fri Jan  5 17:36:36 UTC 2024

Might be worth mentioning in the README if you decide not to support Manjaro.

@dns2utf8
Copy link
Collaborator

dns2utf8 commented Feb 7, 2024

Could you post the output of uname -r because that is the command used to detect the running kernel?

Also, the error reported a missmatch with alpm the pacman API, could you confirm that you have pacman installed?

@rnestler
Copy link
Owner

rnestler commented Feb 7, 2024

I think we can easily support manjaro as well. Can you post the output when you run it with RUST_LOG=info reboot-arch-btw?

@rnestler
Copy link
Owner

rnestler commented Feb 8, 2024

Especially interesting would be how we can map from the uname -r output to the package name on manjaro. Looking at https://packages.manjaro.org/?query=linux it has a lot of different packages for each major/minor Linux version.

@grodin
Copy link
Author

grodin commented Feb 8, 2024

Here's the output of uname -r:

6.1.71-1-MANJARO

and the output of RUST_LOG=info reboot-arch-btw:

[2024-02-08T15:46:16Z INFO  reboot_arch_btw::kernel] uname -r output: 6.1.71-1-MANJARO
[2024-02-08T15:46:16Z INFO  reboot_arch_btw::kernel] Detected kernel package: linux-MANJARO
[2024-02-08T15:46:16Z ERROR reboot_arch_btw] Could not create kernel checker: Could not get version of installed kernel: could not find or read package
[2024-02-08T15:46:16Z INFO  reboot_arch_btw::critical_packages_check] Checking systemd
[2024-02-08T15:46:16Z INFO  reboot_arch_btw::critical_packages_check] Checking linux-firmware
[2024-02-08T15:46:16Z INFO  reboot_arch_btw::critical_packages_check] Checking amd-ucode
[2024-02-08T15:46:16Z WARN  reboot_arch_btw::critical_packages_check] Failed to get package info for amd-ucode
[2024-02-08T15:46:16Z INFO  reboot_arch_btw::critical_packages_check] Checking intel-ucode
[2024-02-08T15:46:16Z INFO  reboot_arch_btw::critical_packages_check] Checking xorg-server
[2024-02-08T15:46:16Z INFO  reboot_arch_btw::critical_packages_check] Checking xorg-xwayland
[2024-02-08T15:46:16Z WARN  reboot_arch_btw::critical_packages_check] Failed to get package info for xorg-xwayland

@rnestler
Copy link
Owner

rnestler commented Feb 8, 2024

@grodin And do you happen to know what the actual installed kernel package name is on your system? Probably linux61?

@grodin
Copy link
Author

grodin commented Feb 8, 2024

@grodin And do you happen to know what the actual installed kernel package name is on your system? Probably linux61?

Exactly right

@rnestler
Copy link
Owner

rnestler commented Feb 8, 2024

So I guess we could infer the package name from the major and minor version of the uname output.

@rnestler
Copy link
Owner

rnestler commented Feb 8, 2024

Can you try the fix in #165?

@grodin
Copy link
Author

grodin commented Feb 8, 2024

It seems to work. I checked out #165 and did a debug build. The output of target/debug/reboot-arch-btw is

Kernel
 installed: 6.1.71.1 (since 24 days ago)
 running:   6.1.71.1-MANJARO

Is that what you'd expect?

@rnestler
Copy link
Owner

rnestler commented Feb 9, 2024

Is that what you'd expect?

This seems reasonable. One could argue that it is a bit confusing that the installed version doesn't include -MANJARO, but I guess we can live with that.

If you run into any other issues with Manjaro, just open another ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants