Is wf_owner updated for non-marc records? Should it? #1584
Comments
|
After some more tests, I understand better the current behaviour: a new non-Marc record, either created via the new button or via a bibliographic, effectively creates the We are interested in updating it, so we know who did this modification. |
|
I think we just never implemented it, we never really used this functionality (since only editors can touch auth files), but if you want to patch it go ahead! |
Make this field visible in the display page, and update it using current user field. After uptading, redirect to the display page, because if redirects to the list, the modified record is lost and not easily accessible, except via the browser history. Closes rism-digital#1584
Currently, after editing those records, Muscat takes you to the record list, without allowing to double-check if the editing was right. Partially closes rism-digital#1584
|
The proposal is not accepted, as seen in the discussion at #1589, so I'm closing it. |
|
The problem in #1589 is not really using wf_owner, it is that it would be changed to the user logged in every time the record is saved! I think wf_owner should be and "owner" that stays the same unless explicitly changed by an editor. To know the history of who edits a record, :versions can be used, as each time a record is saved an old version with the name of the user is saved. So for me: ok to use wf_owner everywhere, but it should not be changed each time the record is saved. |
|
I understand. The problem with my PR is that it was doing three different things: making wf_owner always visible in all those non-marc authority record, updating it at each update, and redirecting to the full record instead to the list. So it caused confusion and discussion, my fault. In my defense, I can say that some PR take so much time to be incorporated, sometimes accepted ( #1363), others without comments (#1651), that I wanted to rush a little bit this incorporation, knowing, of course, that it is better not to mix different fixes in the same patch. My pile of pending contributions is growing locally in our servers, but they depend on the pending ones to be accepted (or not!). Anyway, #1695 is in the queue, and I'll create another one for showing wf_owner for those non-marc authority records, without updating each time the record is saved. |
|
Moreover, those non-marc authority records do not have versions. So we thought that a simple way to know who did the last edit was updating the owner. It is acceptable in our environment, but it may be not in yours, of course. |
Those records already had an ownwer, but it was not visible on the screen. Fixes rism-digital#1584
Of all non-marc authority records, place is the only that doesn't display wf_stage, although the field exists in the database. Make it visible, so it is homogeneous with the others. Part of rism-digital#1584
I've just discovered that in my Muscat instances,
wf_owneris updated only for Marc records (publications, sources, people, institutions, etc), but not for standard_titles, standard_terms, places or liturgical_feasts, even after effectively updating records. I'm pretty sure that I haven't patched anything related to this, but may I ask if it happens also in your instances, please?If not, would you agree that it should be updated?
I have seen that all models, Marc and non-Marc, have the same
belongs_to :user, :foreign_key => "wf_owner"statement, so the reason for not being updated appears to be a bug.The text was updated successfully, but these errors were encountered: