Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv_isac dependency not updated #122

Open
5hayanB opened this issue Jul 29, 2024 · 3 comments
Open

riscv_isac dependency not updated #122

5hayanB opened this issue Jul 29, 2024 · 3 comments

Comments

@5hayanB
Copy link

5hayanB commented Jul 29, 2024

Cloned the riscof framework via the command which went smoothly:

pip3 install git+https://github.com/riscv/riscof.git

However, running riscof via the command:

riscof --verbose info arch-test --clone

I am greeted with the following error:

File "$HOME/.venv/bin/riscof", line 5, in <module>
    from riscof.cli import cli
  File "$HOME/.venv/lib/python3.12/site-packages/riscof/cli.py", line 18, in <module>
    import riscof.framework.main as framework
  File "$HOME/.venv/lib/python3.12/site-packages/riscof/framework/main.py", line 11, in <module>
    from riscv_isac.isac import preprocessing
ImportError: cannot import name 'preprocessing' from 'riscv_isac.isac' ($HOME/.venv/lib/python3.12/site-packages/riscv_isac/isac.py)

On debugging the problem, I found out that the recent commit dddbc52 added import statements from isac.py of the dev branch. But the riscv_isac dependency is not updated in requirements.txt. Reverting to commit d38859f fixes the problem.

@stnolting-ims
Copy link

I can confirm this bug (https://github.com/stnolting/neorv32-riscof/actions/runs/10156350492/job/28086317621#step:7:43).

Reverting to commit d38859f fixes the problem.

This seems to fix this (as a temporary workaround).

@quswarabid
Copy link

+1

@stnolting
Copy link

It this going to be fixed? Shall we provide a PR to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants