Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable caching token list #1119

Open
shichengripple001 opened this issue Jan 15, 2025 · 6 comments
Open

disable caching token list #1119

shichengripple001 opened this issue Jan 15, 2025 · 6 comments

Comments

@shichengripple001
Copy link

shichengripple001 commented Jan 15, 2025

it seems search a token isn't working.
Can we remove the caching token step? so that we don't have to provide a GCP credential?

@ckniffen
Copy link
Collaborator

ckniffen commented Jan 15, 2025

That is used for the token page. Search is provided by xrpl-meta.

@shichengripple001
Copy link
Author

shichengripple001 commented Jan 15, 2025

can we retrieve the list from xrpl-meta, instead of retrieving from the Bigquery dataset?

@achowdhry-ripple
Copy link
Collaborator

achowdhry-ripple commented Jan 15, 2025

Yes we can, and is planned to be implemented in the first half of 2025 (removing Bigquery usage in Explorer along with a full token page revamp in general).

Separately, I'm not seeing any issues with the token search -- can you describe what issue you're seeing?

@shichengripple001
Copy link
Author

shichengripple001 commented Jan 15, 2025

if i search for RLUSD for example in the search bar, I get a 404.
https://livenet.xrpl.org/search/RLUSD the url generated automatically for the search

@achowdhry-ripple
Copy link
Collaborator

achowdhry-ripple commented Jan 15, 2025

I see how the explorer behavior there is confusing, clicking "enter" doesn't navigate you to the search result intended (need to manually click the result). What we can do is raise an issue for this, with the solution being some form of checking for search results and automatically navigating to the first one.

Will raise a new issue with these details

@achowdhry-ripple
Copy link
Collaborator

Issue here -- #1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants