Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages for broken HTML tag hierarchy #291

Open
tomasherceg opened this issue Dec 23, 2016 · 2 comments
Open

Better error messages for broken HTML tag hierarchy #291

tomasherceg opened this issue Dec 23, 2016 · 2 comments

Comments

@tomasherceg
Copy link
Member

Consider this piece of code:

<ItemTemplate>
    <tr>
        <td>cell with invalid end tag</th>
    </tr>
</ItemTemplate>

DotVVM reports error that the </ItemTemplate> doesn't have its open tag.

It is not a high priority issue to work on, however it is not very intuitive.

@tomasherceg tomasherceg added this to the Version 1.2 milestone Dec 23, 2016
@exyi
Copy link
Member

exyi commented Dec 23, 2016

We should not only fix this issue, but improve entire error reporting from compilation. We should add strict mode, that would fail on warnings ( #101 ) and improve the error page to display all compilation errors and warnings on the page, not just the first one.

@Mylan719
Copy link
Contributor

The compiler is a bit stupid about reporting errors on unclosed tags. There is simple mechanism, that reports it correctly for most cases but that part would have to be rewritten to account for every case. Also it is bit messy from the time it was still a proof of concept.

@tomasherceg tomasherceg modified the milestones: Future, Version 1.2 May 23, 2017
@tomasherceg tomasherceg modified the milestones: Future, Version 2.1 Jun 8, 2018
@tomasherceg tomasherceg removed this from the Version 2.1 milestone Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants