Skip to content
This repository has been archived by the owner on Jun 6, 2021. It is now read-only.

Breaks with Buzz v0.17.x #167

Open
NoelLH opened this issue Apr 5, 2018 · 7 comments
Open

Breaks with Buzz v0.17.x #167

NoelLH opened this issue Apr 5, 2018 · 7 comments

Comments

@NoelLH
Copy link

NoelLH commented Apr 5, 2018

There is 1 call I've noticed so far to setTimeout() which is removed as per BC breaks listed at https://github.com/kriswallsmith/Buzz/blob/master/CHANGELOG.md#0170 - so as of 10 days ago a new composer install with this lib does not work.

Short term I'd suggest this lib should either pin a version range with v0.16 max, or go straight to requiring v0.17 minimum and update all these calls. I'll try to put a PR together for the latter approach today.

Sample broken call log:

In AndroidGCMNotification.php line 83:

Attempted to call an undefined method named "setTimeout" of class "Buzz\Client\Curl".

NoelLH added a commit to NoelLH/RMSPushNotificationsBundle that referenced this issue Apr 5, 2018
NoelLH added a commit to NoelLH/RMSPushNotificationsBundle that referenced this issue Apr 5, 2018
NoelLH added a commit to NoelLH/RMSPushNotificationsBundle that referenced this issue Apr 5, 2018
@NoelLH NoelLH changed the title Breaks with Buzz v0.17.0 Breaks with Buzz v0.17.x Apr 5, 2018
NoelLH added a commit to NoelLH/RMSPushNotificationsBundle that referenced this issue Apr 5, 2018
NoelLH added a commit to NoelLH/RMSPushNotificationsBundle that referenced this issue Apr 5, 2018
NoelLH added a commit to NoelLH/RMSPushNotificationsBundle that referenced this issue Apr 5, 2018
@GenieTim
Copy link

GenieTim commented May 9, 2018

Can confirm. What would be a temporary workaround until @richsage merges the PR?

@NoelLH
Copy link
Author

NoelLH commented May 9, 2018

@BernhardWebstudio You could use my branch directly but the quickest way / smallest change is probably to pin an older Buzz version in your own composer.json, e.g.

...
"kriswallsmith/buzz": "0.16.1",
...

NoelLH added a commit to NoelLH/RMSPushNotificationsBundle that referenced this issue Jun 26, 2018
This will disable both peer and host SSL verification by cURL
@dridi93
Copy link

dridi93 commented Aug 1, 2018

Hi,

@NoelLH

How can i solve (Attempted to call an undefined method named "setTimeout" of class "Buzz\Client\Curl".) plz.

Thanks.

@GenieTim
Copy link

GenieTim commented Aug 4, 2018

Did you make the adjustment in composer.json, @dridi93 , as suggested in his [answer](url
#167 (comment)) to my question? Afterwards, did you run composer update?

@dridi93
Copy link

dridi93 commented Aug 4, 2018

@BernhardWebstudio Yes, when i did that i got "Only instances of PSR7 Response and Buzz responses are allowed"..

@dridi93
Copy link

dridi93 commented Aug 16, 2018

@NoelLH @BernhardWebstudio ... what's new !

@GenieTim
Copy link

I am sorry, with the given information, I cannot help you any further. Either you have the correct version of buzz, then there will be a method setTimeout and the [error](url
#167 (comment)) will not occur, or you do not have the correct version of Buzz and you need to find a way to get the correct, e.g. with the [mentioned](url
#167 (comment)) addition in composer.json before running composer update. If this does not work, you have to investigate; maybe you have another package requiring a different version of buzz? Maybe your error is somewhere else now?

It would be nicest, if @richsage could comment when or why not this PR could get accepted? This would eliminate this error in total...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants