Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skimage imread as_grey vs as_gray #130

Open
gwd666 opened this issue May 13, 2020 · 4 comments
Open

skimage imread as_grey vs as_gray #130

gwd666 opened this issue May 13, 2020 · 4 comments

Comments

@gwd666
Copy link

gwd666 commented May 13, 2020

Just to let you know, make you aware that based on https://stackoverflow.com/questions/58993530/typeerror-self-open-got-an-unexpected-keyword-argument-as-grey-python I ran into that same issue ...
it may require, at least this fixed it for me, a small tweak in goldberg.py
to line 239 and 246
from return imread(image_or_path, as_grey=True) to return imread(image_or_path, as_gray=True)

Otherwise nice piece of work!

@JavisPeng
Copy link

you need reinstall the scikit-image

 pip install scikit-image==0.14.0

@gwd666
Copy link
Author

gwd666 commented Jun 18, 2020

you need reinstall the scikit-image

 pip install scikit-image==0.14.0

Since [I think] they changed the parameter naming in scikit-image 0.15 I get your advice.;
I am on scikit-image 0.17.1 - with the small above tweak to the imread calls it is no big deal;
would there be any other reason for downgrading by ~6 versions, issues with 0.17 and your code I am not aware of?
Otherwise it could just benefit others if we leave this ticket open, in case someone else runs into the same issue?

@gwd666 gwd666 changed the title skimage as_grey vs as_gray skimage imread as_grey vs as_gray Jun 18, 2020
@darkfader
Copy link

so we all just stick to old versions now?

@jose1711
Copy link

I haven't see any issues with a manually patched version either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants