Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does BOS have padding? #35

Open
antoninononooono opened this issue Jun 29, 2024 · 1 comment
Open

Why does BOS have padding? #35

antoninononooono opened this issue Jun 29, 2024 · 1 comment

Comments

@antoninononooono
Copy link

src/phoneme_ids.cpp

I have been reviewing the phonemes_to_ids function in src/phoneme_ids.cpp and noticed that padding (PAD) is inserted after the Beginning of Sentence (BOS) symbol (^). I'm curious about the reasoning behind this implementation choice.

If this decision was intentional, could you kindly clarify why padding is included after BOS? I'm interested to understand the rationale behind this practice.

Additionally, I noticed that padding is not inserted after the End of Sentence (EOS) symbol ($). I'm wondering if there's a specific reason why EOS does not have padding, whereas BOS does.

Thank you in advance for taking the time to provide clarification on this matter. I appreciate your insights into the design decisions behind the code.

@synesthesiam
Copy link
Contributor

I don't have a strong reason for it. I haven't experimented much with different ways of padding (except removing the padding, which seemed to make things worse).
Basically, I went with the first thing that worked well enough 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants