Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexical_cast should check the rest part of parsed string. #153

Open
takei-yuya opened this issue Mar 11, 2014 · 0 comments
Open

lexical_cast should check the rest part of parsed string. #153

takei-yuya opened this issue Mar 11, 2014 · 0 comments

Comments

@takei-yuya
Copy link
Member

Currently, pfi::lang::lexical_cast don't throw any exception for invalid input which has "valid prefix". (e.g. lexical_cast<int>("0.5") )
But caller have no way to check whole of input is valid? or only prefix is valid?
So lexical_cast should throw exception for such input.

And also we need some tests for cast.h to make the spec clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant