Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipping download problem #876

Open
qq430950189 opened this issue Jan 20, 2025 · 2 comments
Open

zipping download problem #876

qq430950189 opened this issue Jan 20, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@qq430950189
Copy link

qq430950189 commented Jan 20, 2025

on linux

[steam@VCi-58O6NQ ~]$ unzip -n cstrike.zip -d /home/steam/Steam/cs16/cstrike/
Archive: cstrike.zip
extracting: /home/steam/Steam/cs16/cstrike/sprites/blueflare1.spr
error: invalid zip file with overlapped components (possible zip bomb)
To unzip the file anyway, rerun the command with UNZIP_DISABLE_ZIPBOMB_DETECTION=TRUE environmnent variable

so what happened?
download with wget -O cstrike.zip http://.../cstrike/?get=zip
the folder is probably up to 300MB

After i set the env .unzipping is ok.

@qq430950189 qq430950189 added the bug Something isn't working label Jan 20, 2025
@qq430950189
Copy link
Author

qq430950189 commented Jan 20, 2025

i don't test on other platform because of network problem.
using the latest version 0.55.4 on linux x86_64

@rejetto
Copy link
Owner

rejetto commented Jan 21, 2025

surely our zip is not a zipbomb: a zipbomb uses an extremely high compression rate to try to fill your disk.
hfs doesn't compress at all, to save your cpu.
Anyway, our zip is a bit peculiar, because we create the zip in streaming, to not even use your disk space for it. For example: if you have 1GB of free space, you can still download a 10GB zip from hfs, because this zip will not be really created. It's somewhat "virtual".
maybe something in it is a bit strange and it triggers the warning in your "unzip".
i tried "unzip" on my mac, and gives no warning. Don't have linux at hand at the moment to make a test.

can you see if you can produce a zip with hfs that gives NO such warning?
just to understand if you get this error with any zip you produce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants