Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Disable minify #6417

Open
pcfreak30 opened this issue Oct 18, 2024 · 2 comments
Open

[FEAT] Disable minify #6417

pcfreak30 opened this issue Oct 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@pcfreak30
Copy link

Is your feature request related to a problem? Please describe.

I have recently discovered a vite configuration issue that I fixed that prevented sourcemaps for refine core from working (I have had a lot of issues before then). However, even with this, is seems at-least 1 code path while debugging skipped an if statement based on the if for no reason at all.

I am requesting the project consider disabling minify in builds so that pages can properly be debugged without needing to jump through hoops as building locally, creating a patch and use pnpm or patch-package is honestly a last resort type of PITA. This to be clear, is so debugging can happen without sourcemaps since I have found they are not always perfect.

Additionally if minify is really considered valuable for a reason I don't need or don't agree with, create a new package export on packages for a different variation.

As I see it minify optimization should be the job of a bundler and npm code should not be pre-minified. It has been a pet peeve of mind as well when i come across this.

Kudos

Describe alternatives you've considered

No response

Additional context

No response

Describe the thing to improve

Disable minify in published builds

@pcfreak30 pcfreak30 added the enhancement New feature or request label Oct 18, 2024
@BatuhanW
Copy link
Member

Hey @pcfreak30 thanks for the issue, we've discussed not pre minifying and it could be a good idea. We need to check if it will have any disadvantages and/or side-effects.

@aliemir
Copy link
Member

aliemir commented Nov 25, 2024

Hey @pcfreak30, thank you for the issue. We'll disable the minification and also update our build process to export individual files instead of bundling them into a single file. This will also resolve some issues we're having with Material UI imports. At least they will be easier to handle or avoid on user side.

I cannot share an exact date for this update but soon we'll share our roadmap for the next major improvements in Refine; they will be non-breaking and will be released gradually rather than packing it in a single major release. Thanks again for your interest and patience 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants