HSet for map[string]float32

[Alvaro948]

Hi,

I have been trying to figure out for some time if this a missing feature or maybe is a missunderstanding, is it possible to call HSet/HMSet with a map[string]float32 or any other map of numbers?, here is an example:

package main

import (
	"context"
	"fmt"
	"github.com/redis/go-redis/v9"
	"github.com/rs/zerolog/log"
)

type UserModel struct {
	Name string `redis:"name"`
	Age  uint64 `redis:"age"`
}

func main() {

	ctx := context.Background()

	client := redis.NewClient(&redis.Options{
		Addr:     fmt.Sprintf("%s:%d", "localhost", 6379),
		Password: "",
		DB:       0,
	})

	user := UserModel{
		Name: "John Doe",
		Age:  30,
	}

	err := client.HMSet(ctx, "user:1", user).Err()

	if err != nil {
		log.Error().Err(err).Msg("Unable to set user")
	}

	scores := make(map[string]float32)
	scores["2024-12-26"] = 21.5
	scores["2024-12-27"] = 25

	err = client.HSet(ctx, "user:1:scores", scores).Err()

	if err != nil {
		log.Fatal().Err(err).Msg("Unable to set user") // Fails due to "redis: can't marshal map[string]float32 (implement encoding.BinaryMarshaler)"
	}
}

Taking a look at https://github.com/redis/go-redis/blob/master/commands.go#L62, is seems that this particular case is missing, maybe something like this would be ok?

func appendArg(dst []interface{}, arg interface{}) []interface{} {
	switch arg := arg.(type) {
	case []string:
		for _, s := range arg {
			dst = append(dst, s)
		}
		return dst
	case []interface{}:
		dst = append(dst, arg...)
		return dst
	case map[string]interface{}:
		for k, v := range arg {
			dst = append(dst, k, v)
		}
		return dst
	case map[string]string:
		for k, v := range arg {
			dst = append(dst, k, v)
		}
		return dst
+	case map[string]float32: // Or any other case
+		for k, v := range arg {
+			dst = append(dst, k, fmt.Sprintf("%f", v))
+		}
+		return dst
	case time.Time, time.Duration, encoding.BinaryMarshaler, net.IP:

A temporary (I hope) workaround I am currently using is to rebuild the map as a part of my custom redis service:

func (repository *RedisRepository) HMSet(key string, value interface{}) error {

	switch arg := value.(type) {
	case map[string]int:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]int8:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]int16:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]int32:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]int64:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]uint:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]uint8:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]uint16:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]uint32:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]uint64:
		value = castMapOfIntegerToString(arg)
		break
	case map[string]float32:
		value = castMapOfFloatToString(arg)
		break
	case map[string]float64:
		value = castMapOfFloatToString(arg)
		break
	}

	err := repository.client.HMSet(ctx, key, value).Err()
	
        [...]
}

func castMapOfIntegerToString[T constraints.Integer](m map[string]T) map[string]string {
	result := make(map[string]string)

	for k, v := range m {
		result[k] = fmt.Sprintf("%d", v)
	}

	return result
}

func castMapOfFloatToString[T constraints.Float](m map[string]T) map[string]string {
	result := make(map[string]string)

	for k, v := range m {
		result[k] = fmt.Sprintf("%f", v)
	}

	return result
}