Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bs circuitbreaker #79

Open
mithereal opened this issue Jan 22, 2019 · 5 comments
Open

add bs circuitbreaker #79

mithereal opened this issue Jan 22, 2019 · 5 comments

Comments

@mithereal
Copy link

mithereal commented Jan 22, 2019

"bs-circuitbreaker": {
"category": "library",
"platforms": ["browser"],
"keywords": ["bucklescript","utilities", "circuit breaker"]
}

@glennsl
Copy link
Member

glennsl commented Jan 23, 2019

Thanks for submitting. I require listed packages to be of a certain standard though. At the very least, the Readme should include a useful description (I have no idea what a circuit breaker even is in this context), installation instructions and a usage example if possible. More information here.

Also, its apparently published to npm as just bs-circuitbreaker, not @mithereal/bs-circuitbreaker.

Could you address this and let me know?

@mithereal
Copy link
Author

added updated example and published

@glennsl
Copy link
Member

glennsl commented Feb 6, 2019

Made a PR to fix the readme a bit. The sloppiness of it made a pretty bad impression, to be honest. Could you merge that, fix the example and publish the changes? It's also still not very clear to me what the benefit of a circuit breaker is compared to just using try/catch and/or promises.

@glennsl glennsl closed this as completed Apr 9, 2019
@glennsl
Copy link
Member

glennsl commented Apr 9, 2019

Spring cleanup. Feel free to reopen when the issues have been addressed.

@glennsl
Copy link
Member

glennsl commented Apr 11, 2019

PR has been merged, but the example is still not valid Reason code, and the embedded JavaScript is not valid JS either.

@glennsl glennsl reopened this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants