Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we get an IPager<T> interface written for Pager<T> class? #663

Open
aleevans opened this issue Oct 14, 2021 · 1 comment · May be fixed by #671
Open

Can we get an IPager<T> interface written for Pager<T> class? #663

aleevans opened this issue Oct 14, 2021 · 1 comment · May be fixed by #671
Labels
question

Comments

@aleevans
Copy link

Would it be possible to get an IPager<T> interface written for the existing Pager<T> class, and have Pager<T> implement it?

With an IPager<T> interface, the IClient interface could then be updated so that all methods which return a Pager<T> now return an IPager<T>.

This would allow my team to mock the pager for testing as well as create a wrapper with added logic.
@rer7891
Copy link
Contributor

rer7891 commented Oct 21, 2021

@aleevans Thanks for bringing both of this issues up. As stated in issue #662 I will make a feature request for this issue. This will be put in our backlog so in the meantime if you need the functionality sooner than our engineers are able to get to it feel free to consider making a PR for the features you would like added. As an open source repository we are always happy to work with engineers on PRs that are submitted. Otherwise we will follow up once the feature request is picked up and the new feature is ready for release.

@quexy quexy linked a pull request Nov 5, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve testing with reculy IClient quexy/recurly-client-dotnet
2 participants
@rer7891 @aleevans