Realm::convert()'s check for unuploaded changes is incorrect

[sync-by-unito]

no_pending_local_changes() checks if there are any untrimmed changesets of local origin, not if there's any unuploaded changesets. Changesets continue to be stored locally after they are uploaded for merging purposes until the server tells us that they are no longer needed, which doesn't always happen at the same time as the upload is acknowledged.

[sync-by-unito]

➤ PM Bot commented:

Jira ticket: RCORE-2232