Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require commitment timeout to be complete before claiming? #20

Open
edmundedgar opened this issue Sep 18, 2019 · 1 comment
Open

Require commitment timeout to be complete before claiming? #20

edmundedgar opened this issue Sep 18, 2019 · 1 comment
Assignees

Comments

@edmundedgar
Copy link
Contributor

The normal claim path only happens after the timeout has elapsed. Since the commitment timeout is shorter than the question timeout, by the time you claim, all commitments have either been revealed or timed out. However, if the answer is submitted by the arbitrator, it's possible (although unlikely) that an answer will not yet have been revealed. The final answer already needs to be checked by the arbitrator contract so they can send the correct answerer, but there may be earlier answers that have not been revealed.

Consider fixing this with a check in _processHistoryItem.

@edmundedgar
Copy link
Contributor Author

@edmundedgar edmundedgar self-assigned this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant