Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge --allow-unsupported-set into --unsupported-set-mode #1380

Open
jasobrown-rs opened this issue Sep 25, 2024 · 2 comments
Open

Merge --allow-unsupported-set into --unsupported-set-mode #1380

jasobrown-rs opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
Medium priority Created by Linear-GitHub Sync Proxying Created by Linear-GitHub Sync

Comments

@jasobrown-rs
Copy link
Contributor

Description

--allow-unsupported-set was added to allow readyset is naively ignore any SET commands it could not process. About a year later, we introduced the --unsupported-set-mode flag and enum. One of the modes available is Allow, that mapped directly onto the existing --allow-unsupported-set.

Confusingly, we did not remove the older flag, and we did not allow setting --unsupported-set-mode allow. Let's reduce our cli flag burden and just merge the two behaviors, into the way it looks like it was intended to be.

@jasobrown-rs jasobrown-rs self-assigned this Sep 25, 2024
@jasobrown-rs jasobrown-rs added Medium priority Created by Linear-GitHub Sync Proxying Created by Linear-GitHub Sync labels Sep 25, 2024
@jasobrown-rs
Copy link
Contributor Author

Duplicate of REA-4673

@jasobrown-rs
Copy link
Contributor Author

Duplicate of #1354

@jasobrown-rs jasobrown-rs marked this as a duplicate of #1354 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium priority Created by Linear-GitHub Sync Proxying Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant