Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning with Sphinx v8.0.2 #312

Closed
Zac-HD opened this issue Oct 8, 2024 · 2 comments · Fixed by #313
Closed

DeprecationWarning with Sphinx v8.0.2 #312

Zac-HD opened this issue Oct 8, 2024 · 2 comments · Fixed by #313

Comments

@Zac-HD
Copy link
Contributor

Zac-HD commented Oct 8, 2024

.../python3.10/site-packages/hoverxref/extension.py:312: RemovedInSphinx90Warning: The '_Opt' object tuple interface is deprecated, use attribute access instead for 'default', 'rebuild', and 'valid_types'.
  default, rebuild, types = app.config.values.get('hoverxref_tooltip_api_host')
.../python3.10/site-packages/hoverxref/extension.py:280: RemovedInSphinx90Warning: The '_Opt' object tuple interface is deprecated, use attribute access instead for 'default', 'rebuild', and 'valid_types'.
  default, rebuild, types = app.config.values.get('hoverxref_modal_class')
.../python3.10/site-packages/hoverxref/extension.py:67: RemovedInSphinx90Warning: The '_Opt' object tuple interface is deprecated, use attribute access instead for 'default', 'rebuild', and 'valid_types'.
  context[attr] = app.config.values[attr][0]

found via this CI run on HypothesisWorks/hypothesis#4129, where we continue to be very happy that hoverxref exists 💖

@humitos
Copy link
Member

humitos commented Oct 8, 2024

Hi 👋🏼 . Would you like to provide a PR? It shouldn't be too hard.

We did a similar work in readthedocs/sphinx-notfound-page#236 for another extension we maintain. Note that we have to check for Sphinx 7.3, tho, since we fixed that in a later PR at readthedocs/sphinx-notfound-page#241

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Nov 13, 2024

Hi Manuel, I've opened #313 to fix this issue 🙂

Thanks for all your work on readthedocs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants