Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate changing TryAddWithoutValidation to Add #1853

Open
ChrisPulman opened this issue Oct 1, 2024 · 1 comment
Open

Investigate changing TryAddWithoutValidation to Add #1853

ChrisPulman opened this issue Oct 1, 2024 · 1 comment
Assignees
@ChrisPulman
Labels
enhancement

Comments

@ChrisPulman
Copy link
Member

Describe the bug 🐞

Method name change investigation

Step to reproduce

Investigate only

Reproduction repository

https://github.com/reactiveui/refit

Expected behavior

N/A

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

Current

Device

No response

Refit Version

No response

Additional information ℹ️

No response
@ChrisPulman ChrisPulman added the bug label Oct 1, 2024
@ChrisPulman ChrisPulman self-assigned this Oct 1, 2024
@TimothyMakkison
Copy link
Contributor

TimothyMakkison commented Oct 2, 2024 •
edited
Loading

While you are at it, do you have thoughts on request.Headers.Any(x => x.Key == name).

It seems unneeded to me, but the comment above suggests that it's necessary 🤷‍♀️
I assumed that Remove mights call Contains internally but I'm still not sure why it's needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisPulman ChrisPulman

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChrisPulman @TimothyMakkison and others