Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniqueKeyForRequest and POST body content #10

Open
ChristopheOosterlynck opened this issue May 27, 2015 · 1 comment
Open

UniqueKeyForRequest and POST body content #10

ChristopheOosterlynck opened this issue May 27, 2015 · 1 comment

Comments

@ChristopheOosterlynck
Copy link

RateLimitedHttpMessageHandler:UniqueKeyForRequest doesn't take into account the content of the HttpRequestMessage when it is a POST request. POST requests which are similar and just have a different content, are considered the same request and only the first one is executed when multiple of those similar POST requests are outstanding. All calls receive the same response while they should actually receive different responses.

@ncruces
Copy link

ncruces commented Dec 17, 2015

In #6 @paulcbetts says "POST/DELETEs don't get cached or deduped", however looking at RateLimitedHttpMessageHandler doesn't seem to support this.

Requests with a body should definitely look at the body before deduplicating it. IMHO, only indeponent requests should ever be deduped. Likely, it'd simpler and "safer" to only support safe methods deduplication: GET and HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants