Skip to content
This repository has been archived by the owner on Jun 18, 2018. It is now read-only.

Drop "React" from the name. #40

Open
kesne opened this issue Aug 18, 2016 · 3 comments
Open

Drop "React" from the name. #40

kesne opened this issue Aug 18, 2016 · 3 comments

Comments

@kesne
Copy link
Collaborator

kesne commented Aug 18, 2016

Originally reported here: react-dnd/react-dnd#513

First off, just want to say thanks for building react-dnd and its core libraries. The abstractions are wonderful to work with and very flexible.

Currently using dnd-core and react-dnd-html5-backend inside of an ember addon and it works great! But, I am using bower to grab the react-dnd-html5-backend because the npm package has a react-dnd peer dependency, which makes sense due to the name of the package. I would like to propose moving the html5 backend into a package named something like dnd-core-html5-backend without the react-dnd peer dep, then updating react-dnd-html5-backend to use dnd-core-html5-backend with the react-dnd peer dependency. If this sounds reasonable, let me know if there is anything I can do to help.

@Samsinite
Copy link

Anything I can do to help move this along?

@darthtrevino
Copy link
Member

Since the project name is now "react-dnd", I don't think we should change the name of the package. However, I do think it would make sense to remove the peer dependency.

@Samsinite
Copy link

Samsinite commented Jan 25, 2017

@darthtrevino

I'm not advocating removing this package, and I see use in a peer dependency, I was advocating updating this package to wrap a package that does not have react-dnd as a peer dependency (which might make sense as well to remove the react name from).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants