From ef65d456e5b015b08c02d1c6463ba67b19b308cf Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Thu, 22 Feb 2024 16:30:37 +0530 Subject: [PATCH 1/8] PoC: Interface for Firebolt Privacy Module --- interfaces/IFireboltPrivacy.h | 57 +++++++++++++++++++++++++++++++++++ interfaces/Ids.h | 5 ++- 2 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 interfaces/IFireboltPrivacy.h diff --git a/interfaces/IFireboltPrivacy.h b/interfaces/IFireboltPrivacy.h new file mode 100644 index 00000000..d59ce7b9 --- /dev/null +++ b/interfaces/IFireboltPrivacy.h @@ -0,0 +1,57 @@ +/* + * If not stated otherwise in this file or this component's LICENSE file the + * following copyright and licenses apply: + * + * Copyright 2022 Metrological + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once +#include "Module.h" + +namespace WPEFramework { +namespace Exchange { + + /* @json 1.0.0*/ + struct EXTERNAL IFireboltPrivacy : virtual public Core::IUnknown { + enum { ID = ID_FIREBOLT_PRIVACY }; + + // @event + struct EXTERNAL INotification : virtual public Core::IUnknown { + enum { ID = ID_FIREBOLT_PRIVACY_NOTIFICATION }; + ~INotification() override = default; + + // @brief Notifies that Allow Resume points value change + /* @alt:OnAllowResumePointsChanged */ + virtual void OnAllowResumePointsChanged(const bool value) = 0; + + }; + + ~IFireboltPrivacy() override = default; + + // Pushing notifications to interested sinks + virtual uint32_t Register(IFireboltPrivacy::INotification* sink) = 0; + virtual uint32_t Unregister(IFireboltPrivacy::INotification* sink) = 0; + + // @property + // @brief Provides Current resume watch status + // @alt:AllowResumePoints + virtual uint32_t AllowResumePoints(bool& allow /* @out */) const = 0; + + // @brief Set resume watch status + // @alt:SetAllowResumePoints + virtual uint32_t SetAllowResumePoints(const bool& value ) = 0; + }; +} +} diff --git a/interfaces/Ids.h b/interfaces/Ids.h index c2ee007f..b73cfe49 100644 --- a/interfaces/Ids.h +++ b/interfaces/Ids.h @@ -378,7 +378,10 @@ namespace Exchange { ID_DNS_SERVER = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x4E0, ID_DNS_ZONE = ID_DNS_SERVER + 1, - ID_DNS_RECORD = ID_DNS_SERVER + 2 + ID_DNS_RECORD = ID_DNS_SERVER + 2, + + ID_FIREBOLT_PRIVACY = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x4F0, + ID_FIREBOLT_PRIVACY_NOTIFICATION = ID_FIREBOLT_PRIVACY + 1 }; } } From 1b02404a092b63f6612b9c1381ba5453944b0458 Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Tue, 5 Mar 2024 23:55:26 -0800 Subject: [PATCH 2/8] Addressing code review comments --- interfaces/IFireboltPrivacy.h | 25 ++++++++++++++++--------- interfaces/Ids.h | 4 ++-- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/interfaces/IFireboltPrivacy.h b/interfaces/IFireboltPrivacy.h index d59ce7b9..0c45d2d4 100644 --- a/interfaces/IFireboltPrivacy.h +++ b/interfaces/IFireboltPrivacy.h @@ -26,6 +26,11 @@ namespace Exchange { /* @json 1.0.0*/ struct EXTERNAL IFireboltPrivacy : virtual public Core::IUnknown { enum { ID = ID_FIREBOLT_PRIVACY }; + enum StorageLocation : uint8_t { + Disk /* @text: Disk */, + InMemory /* @text: InMemory */, + }; + // @event struct EXTERNAL INotification : virtual public Core::IUnknown { @@ -33,7 +38,7 @@ namespace Exchange { ~INotification() override = default; // @brief Notifies that Allow Resume points value change - /* @alt:OnAllowResumePointsChanged */ + /* @text:OnAllowResumePointsChanged */ virtual void OnAllowResumePointsChanged(const bool value) = 0; }; @@ -41,17 +46,19 @@ namespace Exchange { ~IFireboltPrivacy() override = default; // Pushing notifications to interested sinks - virtual uint32_t Register(IFireboltPrivacy::INotification* sink) = 0; - virtual uint32_t Unregister(IFireboltPrivacy::INotification* sink) = 0; + virtual Core::hresult Register(IFireboltPrivacy::INotification* sink) = 0; + virtual Core::hresult Unregister(IFireboltPrivacy::INotification* sink) = 0; - // @property // @brief Provides Current resume watch status - // @alt:AllowResumePoints - virtual uint32_t AllowResumePoints(bool& allow /* @out */) const = 0; + // @text:AllowResumePoints + virtual Core::hresult AllowResumePoints(bool& allow /* @out */) = 0; + // @brief sets the current resume watch status + // @text:SetAllowResumePoints + virtual Core::hresult SetAllowResumePoints(const bool& value ) = 0; - // @brief Set resume watch status - // @alt:SetAllowResumePoints - virtual uint32_t SetAllowResumePoints(const bool& value ) = 0; + // @property + // @brief Get the storage location + virtual Core::hresult GetStorageLocation(StorageLocation& value /* @out */) const = 0; }; } } diff --git a/interfaces/Ids.h b/interfaces/Ids.h index b73cfe49..4098f9b9 100644 --- a/interfaces/Ids.h +++ b/interfaces/Ids.h @@ -380,8 +380,8 @@ namespace Exchange { ID_DNS_ZONE = ID_DNS_SERVER + 1, ID_DNS_RECORD = ID_DNS_SERVER + 2, - ID_FIREBOLT_PRIVACY = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x4F0, - ID_FIREBOLT_PRIVACY_NOTIFICATION = ID_FIREBOLT_PRIVACY + 1 + ID_FIREBOLT_PRIVACY = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x4F0, + ID_FIREBOLT_PRIVACY_NOTIFICATION = ID_FIREBOLT_PRIVACY + 1 }; } } From c2f6bd669561f3d42525cb009f4a2bd9c8072cc4 Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Wed, 20 Mar 2024 08:10:59 -0700 Subject: [PATCH 3/8] Addressing code review comments --- interfaces/IFireboltPrivacy.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/interfaces/IFireboltPrivacy.h b/interfaces/IFireboltPrivacy.h index 0c45d2d4..81b0c0d9 100644 --- a/interfaces/IFireboltPrivacy.h +++ b/interfaces/IFireboltPrivacy.h @@ -27,8 +27,8 @@ namespace Exchange { struct EXTERNAL IFireboltPrivacy : virtual public Core::IUnknown { enum { ID = ID_FIREBOLT_PRIVACY }; enum StorageLocation : uint8_t { - Disk /* @text: Disk */, - InMemory /* @text: InMemory */, + Disk, + InMemory, }; @@ -51,13 +51,14 @@ namespace Exchange { // @brief Provides Current resume watch status // @text:AllowResumePoints - virtual Core::hresult AllowResumePoints(bool& allow /* @out */) = 0; + virtual Core::hresult GetAllowResumePoints(bool& allow /* @out */) const = 0; // @brief sets the current resume watch status // @text:SetAllowResumePoints virtual Core::hresult SetAllowResumePoints(const bool& value ) = 0; // @property // @brief Get the storage location + // @text: GetStorageLocation1 virtual Core::hresult GetStorageLocation(StorageLocation& value /* @out */) const = 0; }; } From f890ab9e83e11c81effd188e75f22155266f46c7 Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Mon, 13 May 2024 00:14:23 -0700 Subject: [PATCH 4/8] WIP Firebolt headers --- interfaces/IFireboltDiscovery.h | 76 +++++++++++++++++++++++++++++++++ interfaces/IFireboltPrivacy.h | 13 ++++-- interfaces/Ids.h | 5 ++- 3 files changed, 90 insertions(+), 4 deletions(-) create mode 100644 interfaces/IFireboltDiscovery.h diff --git a/interfaces/IFireboltDiscovery.h b/interfaces/IFireboltDiscovery.h new file mode 100644 index 00000000..4dfc1fdc --- /dev/null +++ b/interfaces/IFireboltDiscovery.h @@ -0,0 +1,76 @@ +/* + * If not stated otherwise in this file or this component's LICENSE file the + * following copyright and licenses apply: + * + * Copyright 2024 Metrological + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once +#include "Module.h" + +// @insert + +namespace WPEFramework { + +namespace Exchange { + + struct EXTERNAL IFireboltDiscovery : virtual public Core::IUnknown { + + enum { ID = ID_FIREBOLT_DISCOVERY }; + + virtual Core::hresult watched(const string& appId) = 0; + }; + + namespace JSONRPC { + + /* @json 1.0.0 */ + struct EXTERNAL IFireboltDiscovery { + + virtual ~IFireboltDiscovery() = default; + + + // @event + struct EXTERNAL INotification { + + virtual ~INotification() = default; + + // @text onNavigateTo + // @brief Notifies that permision for resume points value has been changed + // @param appId: ID of the applocation for which this notification relates to + // @param allow: Allow or deny use of resume points + virtual void OnNavigateTo(const string& appId /* @index */, const bool allow) = 0; + + // @text onPolicyChanged + // @brief Notifies that a resume point has been added, updated or removed + // @param appId: ID of the application for which this notification relates to + virtual void OnPolicyChanged(const string& appId /* @index */) = 0; + }; + virtual Core::hresult Register(IFireboltDiscovery::INotification* sink) = 0; + virtual Core::hresult UnRegister(IFireboltDiscovery::INotification* sink) = 0; + + // @text PermitResumePoints + // @brief Sets resume point permission + // @details AppID shall be passed through the security token. + // @param allow: Allow or deny use of resume points + // @retval ERROR_PRIVILIGED_REQUEST: App security errors + virtual Core::hresult PermitResumePoints(const Core::JSONRPC::Context& context, const Core::OptionalType param ) = 0; + + }; + + } // namespace JSONRPC + +} // namespace Exchange + +} diff --git a/interfaces/IFireboltPrivacy.h b/interfaces/IFireboltPrivacy.h index 81b0c0d9..085b375c 100644 --- a/interfaces/IFireboltPrivacy.h +++ b/interfaces/IFireboltPrivacy.h @@ -19,7 +19,6 @@ #pragma once #include "Module.h" - namespace WPEFramework { namespace Exchange { @@ -42,6 +41,11 @@ namespace Exchange { virtual void OnAllowResumePointsChanged(const bool value) = 0; }; + struct entitlements { + string entitlements; + string startTime; + string endTime; + }; ~IFireboltPrivacy() override = default; @@ -51,11 +55,14 @@ namespace Exchange { // @brief Provides Current resume watch status // @text:AllowResumePoints - virtual Core::hresult GetAllowResumePoints(bool& allow /* @out */) const = 0; + virtual Core::hresult GetAllowResumePoints(const string& appId, bool& allow /* @out */) const = 0; // @brief sets the current resume watch status // @text:SetAllowResumePoints - virtual Core::hresult SetAllowResumePoints(const bool& value ) = 0; + virtual Core::hresult SetAllowResumePoints(const string& appId, const bool& value ) = 0; + // @brief sets the current resume watch status + // @text:SignIn + virtual Core::hresult SignIn(const string& appId, const entitlements& entitilements) = 0; // @property // @brief Get the storage location // @text: GetStorageLocation1 diff --git a/interfaces/Ids.h b/interfaces/Ids.h index 4098f9b9..5cb8e711 100644 --- a/interfaces/Ids.h +++ b/interfaces/Ids.h @@ -381,7 +381,10 @@ namespace Exchange { ID_DNS_RECORD = ID_DNS_SERVER + 2, ID_FIREBOLT_PRIVACY = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x4F0, - ID_FIREBOLT_PRIVACY_NOTIFICATION = ID_FIREBOLT_PRIVACY + 1 + ID_FIREBOLT_PRIVACY_NOTIFICATION = ID_FIREBOLT_PRIVACY + 1, + + ID_FIREBOLT_DISCOVERY = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x500, + ID_FIREBOLT_DISCOVERY_NOTIFICATION = ID_FIREBOLT_DISCOVERY + 1 }; } } From 341109ecd1a85aeb984bac84368eb2e0c48395c9 Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Tue, 14 May 2024 01:18:56 -0700 Subject: [PATCH 5/8] Adding FireboltDisccovery WIP --- interfaces/IFireboltDiscovery.h | 29 +++++------------------------ interfaces/IFireboltPrivacy.h | 7 ------- 2 files changed, 5 insertions(+), 31 deletions(-) diff --git a/interfaces/IFireboltDiscovery.h b/interfaces/IFireboltDiscovery.h index 4dfc1fdc..314105b5 100644 --- a/interfaces/IFireboltDiscovery.h +++ b/interfaces/IFireboltDiscovery.h @@ -26,7 +26,7 @@ namespace WPEFramework { namespace Exchange { - struct EXTERNAL IFireboltDiscovery : virtual public Core::IUnknown { + struct EXTERNAL IFDiscovery : virtual public Core::IUnknown { enum { ID = ID_FIREBOLT_DISCOVERY }; @@ -41,31 +41,12 @@ namespace Exchange { virtual ~IFireboltDiscovery() = default; - // @event - struct EXTERNAL INotification { - - virtual ~INotification() = default; - - // @text onNavigateTo - // @brief Notifies that permision for resume points value has been changed - // @param appId: ID of the applocation for which this notification relates to - // @param allow: Allow or deny use of resume points - virtual void OnNavigateTo(const string& appId /* @index */, const bool allow) = 0; - - // @text onPolicyChanged - // @brief Notifies that a resume point has been added, updated or removed - // @param appId: ID of the application for which this notification relates to - virtual void OnPolicyChanged(const string& appId /* @index */) = 0; - }; - virtual Core::hresult Register(IFireboltDiscovery::INotification* sink) = 0; - virtual Core::hresult UnRegister(IFireboltDiscovery::INotification* sink) = 0; - - // @text PermitResumePoints - // @brief Sets resume point permission + // @text SignIn + // @brief Signin the user in the app // @details AppID shall be passed through the security token. - // @param allow: Allow or deny use of resume points + // @param param: SignInParam // @retval ERROR_PRIVILIGED_REQUEST: App security errors - virtual Core::hresult PermitResumePoints(const Core::JSONRPC::Context& context, const Core::OptionalType param ) = 0; + virtual Core::hresult SignIn(const Core::JSONRPC::Context& context, const bool param ) = 0; }; diff --git a/interfaces/IFireboltPrivacy.h b/interfaces/IFireboltPrivacy.h index 085b375c..4a8edf27 100644 --- a/interfaces/IFireboltPrivacy.h +++ b/interfaces/IFireboltPrivacy.h @@ -60,13 +60,6 @@ namespace Exchange { // @text:SetAllowResumePoints virtual Core::hresult SetAllowResumePoints(const string& appId, const bool& value ) = 0; - // @brief sets the current resume watch status - // @text:SignIn - virtual Core::hresult SignIn(const string& appId, const entitlements& entitilements) = 0; - // @property - // @brief Get the storage location - // @text: GetStorageLocation1 - virtual Core::hresult GetStorageLocation(StorageLocation& value /* @out */) const = 0; }; } } From d75318549be6f5044d39de6fbf720aae5167e813 Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Mon, 24 Jun 2024 03:06:10 -0700 Subject: [PATCH 6/8] Adding FireboltDiscovery interface --- interfaces/IFireboltDiscovery.h | 49 +++++++++++++++++++++++++++++---- interfaces/IFireboltPrivacy.h | 30 ++++++++++++++------ interfaces/Ids.h | 3 +- 3 files changed, 67 insertions(+), 15 deletions(-) diff --git a/interfaces/IFireboltDiscovery.h b/interfaces/IFireboltDiscovery.h index 314105b5..89d1743b 100644 --- a/interfaces/IFireboltDiscovery.h +++ b/interfaces/IFireboltDiscovery.h @@ -26,9 +26,34 @@ namespace WPEFramework { namespace Exchange { - struct EXTERNAL IFDiscovery : virtual public Core::IUnknown { + + struct EXTERNAL IFireboltDiscovery : virtual public Core::IUnknown { enum { ID = ID_FIREBOLT_DISCOVERY }; +#if 1 + struct EXTERNAL DiscoveryPolicy{ + uint8_t enableRecommendation; + uint8_t shareWatchHistory; + uint8_t rememberWatchedProgram; + }; +#endif +#if 1 + // @event + struct EXTERNAL INotification : virtual public Core::IUnknown { + enum { ID = ID_FIREBOLT_DISCOVERY_NOTIFICATION }; + ~INotification() override = default; + + // @brief Notifies that PolicyValue Changed + /* @text:onPolicyChanged */ + virtual void OnPolicyChanged(const struct DiscoveryPolicy policy) = 0; + }; + + // Pushing notifications to interested sinks + virtual Core::hresult Register(IFireboltDiscovery::INotification* sink) = 0; + virtual Core::hresult Unregister(IFireboltDiscovery::INotification* sink) = 0; +#endif + // @brief Provides Current Policy in action + virtual Core::hresult GetDiscoveryPolicy(DiscoveryPolicy& policy /* @out */) = 0; virtual Core::hresult watched(const string& appId) = 0; }; @@ -36,17 +61,31 @@ namespace Exchange { namespace JSONRPC { /* @json 1.0.0 */ - struct EXTERNAL IFireboltDiscovery { + struct EXTERNAL IFireboltDiscoveryJSONRPC { + + virtual ~IFireboltDiscoveryJSONRPC() = default; - virtual ~IFireboltDiscovery() = default; + /* @event */ + struct EXTERNAL INotification { + virtual ~INotification() = default; + + // @brief Notifies change in the discovery policy + virtual void PolicyChanged(const IFireboltDiscovery::DiscoveryPolicy policy) = 0; + }; // @text SignIn // @brief Signin the user in the app // @details AppID shall be passed through the security token. - // @param param: SignInParam + // @param signin: True - SignIn + // @retval ERROR_PRIVILIGED_REQUEST: App security errors + virtual Core::hresult SignIn(const Core::JSONRPC::Context& context, const bool signin /*@optional*/) = 0; + + // @text Policy + // @brief Signin the user in the app + // @details Get the current Discovery Policy // @retval ERROR_PRIVILIGED_REQUEST: App security errors - virtual Core::hresult SignIn(const Core::JSONRPC::Context& context, const bool param ) = 0; + virtual Core::hresult Policy(const Core::JSONRPC::Context& context, IFireboltDiscovery::DiscoveryPolicy& policy /*@out*/) = 0; }; diff --git a/interfaces/IFireboltPrivacy.h b/interfaces/IFireboltPrivacy.h index 4a8edf27..f5ccaf98 100644 --- a/interfaces/IFireboltPrivacy.h +++ b/interfaces/IFireboltPrivacy.h @@ -37,14 +37,14 @@ namespace Exchange { ~INotification() override = default; // @brief Notifies that Allow Resume points value change - /* @text:OnAllowResumePointsChanged */ + /* @text:onAllowResumePointsChanged */ virtual void OnAllowResumePointsChanged(const bool value) = 0; - - }; - struct entitlements { - string entitlements; - string startTime; - string endTime; + // @brief Notifies that Allow personalization value change + /* @text:onAllowPersonalizationChanged */ + virtual void OnAllowPersonalizationChanged(const bool value) = 0; + // @brief Notifies that Allow Watch History value change + /* @text:onAllowWatchHistoryChanged */ + virtual void OnAllowWatchHistoryChanged(const bool value) = 0; }; ~IFireboltPrivacy() override = default; @@ -55,10 +55,22 @@ namespace Exchange { // @brief Provides Current resume watch status // @text:AllowResumePoints - virtual Core::hresult GetAllowResumePoints(const string& appId, bool& allow /* @out */) const = 0; + virtual Core::hresult GetAllowResumePoints(bool& allow /* @out */) const = 0; // @brief sets the current resume watch status // @text:SetAllowResumePoints - virtual Core::hresult SetAllowResumePoints(const string& appId, const bool& value ) = 0; + virtual Core::hresult SetAllowResumePoints(const bool& value ) = 0; + // @brief Provides Current resume watch status + // @text:AllowPersonalization + virtual Core::hresult GetAllowPersonalization(bool& allow /* @out */) const = 0; + // @brief sets the current resume watch status + // @text:SetAllowPersonalization + virtual Core::hresult SetAllowPersonalization(const bool& value ) = 0; + // @brief Provides Current resume watch status + // @text:AllowWatchHistory + virtual Core::hresult GetAllowWatchHistory(bool& allow /* @out */) const = 0; + // @brief sets the current resume watch status + // @text:SetAllowWatchHistory + virtual Core::hresult SetAllowWatchHistory(const bool& value ) = 0; }; } diff --git a/interfaces/Ids.h b/interfaces/Ids.h index 5cb8e711..a0c6c65c 100644 --- a/interfaces/Ids.h +++ b/interfaces/Ids.h @@ -384,7 +384,8 @@ namespace Exchange { ID_FIREBOLT_PRIVACY_NOTIFICATION = ID_FIREBOLT_PRIVACY + 1, ID_FIREBOLT_DISCOVERY = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x500, - ID_FIREBOLT_DISCOVERY_NOTIFICATION = ID_FIREBOLT_DISCOVERY + 1 + ID_FIREBOLT_DISCOVERY_NOTIFICATION = ID_FIREBOLT_DISCOVERY + 1, + ID_FIREBOLT_DISCOVERY_POLICY = ID_FIREBOLT_DISCOVERY + 2 }; } } From c81a6bbe471ced947b44fd8eb201fd1585fdb34c Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Wed, 17 Jul 2024 17:45:41 +0530 Subject: [PATCH 7/8] Update IFireboltDiscovery.h Correcting member datatypes in Discoverypolicy --- interfaces/IFireboltDiscovery.h | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/interfaces/IFireboltDiscovery.h b/interfaces/IFireboltDiscovery.h index 89d1743b..3e3d108f 100644 --- a/interfaces/IFireboltDiscovery.h +++ b/interfaces/IFireboltDiscovery.h @@ -30,14 +30,12 @@ namespace Exchange { struct EXTERNAL IFireboltDiscovery : virtual public Core::IUnknown { enum { ID = ID_FIREBOLT_DISCOVERY }; -#if 1 struct EXTERNAL DiscoveryPolicy{ - uint8_t enableRecommendation; - uint8_t shareWatchHistory; - uint8_t rememberWatchedProgram; + bool enableRecommendation; + bool shareWatchHistory; + bool rememberWatchedProgram; }; -#endif -#if 1 + // @event struct EXTERNAL INotification : virtual public Core::IUnknown { enum { ID = ID_FIREBOLT_DISCOVERY_NOTIFICATION }; @@ -51,7 +49,7 @@ namespace Exchange { // Pushing notifications to interested sinks virtual Core::hresult Register(IFireboltDiscovery::INotification* sink) = 0; virtual Core::hresult Unregister(IFireboltDiscovery::INotification* sink) = 0; -#endif + // @brief Provides Current Policy in action virtual Core::hresult GetDiscoveryPolicy(DiscoveryPolicy& policy /* @out */) = 0; From 8c16e1dfb414a5e215b5ba82487e72b34c546b61 Mon Sep 17 00:00:00 2001 From: Karthick Somasundaresan Date: Wed, 17 Jul 2024 17:46:31 +0530 Subject: [PATCH 8/8] Update IFireboltPrivacy.h Removing unused struct --- interfaces/IFireboltPrivacy.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/interfaces/IFireboltPrivacy.h b/interfaces/IFireboltPrivacy.h index f5ccaf98..3b5421af 100644 --- a/interfaces/IFireboltPrivacy.h +++ b/interfaces/IFireboltPrivacy.h @@ -25,11 +25,6 @@ namespace Exchange { /* @json 1.0.0*/ struct EXTERNAL IFireboltPrivacy : virtual public Core::IUnknown { enum { ID = ID_FIREBOLT_PRIVACY }; - enum StorageLocation : uint8_t { - Disk, - InMemory, - }; - // @event struct EXTERNAL INotification : virtual public Core::IUnknown {