Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning Core > 2.11.0 Unsupported on older browsers #536

Open
SemHelevenAndrome opened this issue May 22, 2024 · 4 comments
Open

Lightning Core > 2.11.0 Unsupported on older browsers #536

SemHelevenAndrome opened this issue May 22, 2024 · 4 comments

Comments

@SemHelevenAndrome
Copy link

Hi,
while updating the lng core and sdk to the latest versions (2.13.1 and 5.5.3) We noticed that Lightning crashes on older browsers. We would like to support Samsung 2017 tvs and LG 2017 tvs. These use a chromium browser v47 and v38 respectively. When using lng dev, there seems to be error in the startApp.js file, where:

var url = new URL(document.location.href);
resolve(url.searchParams.has('texture'));

url.searchParams is supported from chrome 51.
image
When changing this to resolve true (for testing), we get a different error where bundle is undefined.
image

This seems to be the case even when using core v2.12.0. This did work on core v2.11.0 (currently in use). This would prevent us from updating our lng core. Which is not ideal.
Can these older browser stay supported? Thanks in advance.

Kind regards
Sem

@elsassph
Copy link
Contributor

We do that: https://www.npmjs.com/package/url-polyfill

@SemHelevenAndrome
Copy link
Author

I just tried with an minimal app. So only lng create and then lng dist --es5. And it gives some strange errors on chrome 37.
image
On latest sdk with corresponding core version it does not work. On sdk 5.5.1 with core 2.12.1 it does not work. On lower (sdk 5.5.0 and core 2.11.0) it all works perfectly. Can this backwards compatibility be fixed or will this no longer be supported?

@SemHelevenAndrome
Copy link
Author

Any update on this? It seems that the compiled lng core does not support these older browsers. And should be transpiled/ build to support these older browsers. To me it does not seem possible to rebuild this node module when building the lng app, using lng dist.

@SemHelevenAndrome
Copy link
Author

Hi, I have narrowed it down to this commit: e52364a from @frank-weindel. From this commit, the es5 build no longer works due to the unexpected strict mode reserved word, on older browser (Chrome 38). Can I get some help because I don't understand why it has stopped working. Many thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants