Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Move Markers on a JMPBody Moves Different Markers by Different Amounts #318

Open
bfregly opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bfregly
Copy link
Contributor

bfregly commented Apr 12, 2024

Describe the bug
Run JMP with settings file that

  1. Makes torsue a JMPBody and scale torso, and
  2. Makes pelvis a JMPBody and allow pelvis markers to move in Y direction.
  3. Sets <anatomical_markers> to true so that torso markers scale with torso.

JMP'ed model has R_ASIS and L_ASIS markers moved upward by different amounts.

Both ASIS markers + Sacral marker should all move upward by the same amount in the pelvis body.

To Reproduce
Steps to reproduce the behavior:
Run the attached JMP settings file JMPScaleModelMoveMarkers_b.xml.

Expected behavior
All pelvis markers should have moved upward or downward in the pelvis by the same amount.

Screenshots
If applicable, add screenshots to help explain your problem.

I think JMP may be moving all pelvis markers by the same amount - just not in the same positive or negative direction.

Desktop (please complete the following information):

Screenshot
  • OpenSim Version: 4.5
  • MATLAB Version: 2023a
  • NMSM Pipeline Version: v1.1

Additional context
Add any other context about the problem here.

@bfregly bfregly added the bug Something isn't working label Apr 12, 2024
@cvhammond
Copy link
Member

When body scaling and marker motion were added to JMP it was determined in an NIH team meeting that each marker should move independently because the purpose of the marker motion was to absorb small errors between the static trial used in the OpenSim GUI Scale Tool and the gait/joint trial used for JMP.

Marker motion with JMP was not designed for a use case where all markers needed to be moved as a group because the model is supposed to be scaled properly before coming to JMP. Marker motion is for small marker-specific movements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants