Script Does not Properly Check Ocata Status

[seancarlisle]

If the upgrade script fails after executing prepare-ocata-upgrade.yml or the db migrations, but before the upgrade to Ocata is marked complete, the script will never be able to progress forward due to inventory changes and bad conditional checks.

The prepare-ocata-upgrade.yml playbook touches the file /etc/openstack_deploy/rpc-upgrades/ocata_upgrade_prep.complete, but the conditional check in incremental/lib/functions.sh searches for the file /etc/openstack_deploy/ocata_upgrade_prep.complete, which will never exist.

https://github.com/rcbops/rpc-upgrades/blob/master/incremental/playbooks/prepare-ocata-upgrade.yml#L111-L115

https://github.com/rcbops/rpc-upgrades/blob/master/incremental/lib/functions.sh#L283-L285

Consequently, if the upgrade script fails before Ocata is marked complete, this step will always be executed and will fail because it will try to access the nova_placement_api containers before they are created.

The db-migration-ocata.yml playbook touches the file /etc/openstack_deploy/rpc-upgrades/ocata_migrate.complete, but the conditional check in incremental/lib/functions.sh searches for the file /etc/openstack_deploy/ocata_migrate.complete, which will never exist.

https://github.com/rcbops/rpc-upgrades/blob/master/incremental/playbooks/db-migration-ocata.yml#L156-L164

https://github.com/rcbops/rpc-upgrades/blob/master/incremental/lib/functions.sh#L287-L290

Consequently, if the playbooks fail here, before Ocata is marked complete, the prepare-ocata-upgrade.yml will always be re-ran and will fail for the reason mentioned above.