Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glisten.send() using deprecated BytesBuilder type #25

Closed
Suguis opened this issue Nov 16, 2024 · 2 comments
Closed

glisten.send() using deprecated BytesBuilder type #25

Suguis opened this issue Nov 16, 2024 · 2 comments

Comments

@Suguis
Copy link

Suguis commented Nov 16, 2024

First of all, wanted to say hi 👋. I'm pretty new to the Gleam community and language, and quite new to contributing to open source in general. So feedback is appreciated.

I use glisten for a project. When updating to stdlib 0.42.0, I noticed that the bytes_builder module was deprecated in favor of the bytes_tree module. This is a simple name change due to usage confusion because of the "builder" prefix, see gleam-lang/stdlib#737.

The problem is that glisten.send() needs a param of the deprecated type BytesBuilder. So that function will need to accept a BytesTree instead. Also, there are also some deprecated functions used out there in the code (like result.nil_error).

If it's not a problem, I could do a PR to fix these deprecations. I think it's easy to do it since the changes are small and trivial. Thanks!

@rawhat
Copy link
Owner

rawhat commented Nov 16, 2024

Thank you for the interest! My apologies, but I did already update this. I'll need to do a version release, and I suspect your code might still warn because the gleam/bytes_builder module still exists and references itself.

Didn't mean to take the contribution from you! Welcome to Gleam and hope you enjoy your time 😄

@rawhat rawhat closed this as completed Nov 16, 2024
@Suguis
Copy link
Author

Suguis commented Nov 16, 2024

Don't worry, glad to know it's already taken in account for next release. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants