Fix segfault when unable to connect to stdio_usb device #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect USB devices that failed to open separately from ones that did, to prevent segfaults. Fixes #151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
dr_vidpid_stdio_usb_cant_connectto thepicoboot_device_resultenum, to provide a more useful error when picotool is unable to connect to a device using stdio_usb. The current behaviour was a segfault in this situation, so this now fixes #151This also builds on #154 to add the correct device to the error message when a stdio_usb device is discovered, rather than just printing RP-series.